Repository navigation
Say when the API check runs and who sees the console alert - #37
Merged
Merged
Conversation
The README said every build checks Bukkit API use, but only the Build workflow does: mvn clean package, Dev Release and Release do not. It also said Build runs on every push, not just pushes to main, and left out the manual trigger that has republished dev three times since #30. The console alert is sent to any sender that is not a Player, so the user guide and command reference now say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric, performed inline in a headless dispatch. This is not an independent review. A Copilot review could not be requested (
Judgment call: the This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Stage A documentation sweep compared every doc against
Main.java,plugin.yml,pom.xml, the tests and the three workflows. Four inaccuracies were found and fixed:README.md,CONTRIBUTING.md). The README said "every build" checks Bukkit API use. Onlybuild.ymlruns that step;mvn clean package,dev-release.ymlandrelease.ymldo not. A contributor with a green local build could therefore still fail it on a pull request, andCONTRIBUTING.mdnow says so.README.md). "Every push and pull request" is now "every push tomainand every pull request against it", matchingon:inbuild.yml.README.md).dev-release.ymlalso has aworkflow_dispatchtrigger, used on 2026-10-25, 10-30 and 10-31. This is why thedevtag currently sits on docs-only commit4997c96, which the README's push rule alone cannot explain.USER_GUIDE.md,COMMANDS.md,CHANGELOG.md).Main.javasendsAlert: Can't be used by console.when!(sender instanceof Player), so command blocks and other non-player senders receive it too.No tracking issue — gaps found during triage.
Validation
No code, manifest or workflow files are changed.
mvn -q -B clean packageproducedtarget/FlyCommand-1.0.1.jar; surefire reportedTests run: 4, Failures: 0, Errors: 0(FlyCommandTest) andTests run: 3, Failures: 0, Errors: 0(PluginManifestTest). Those tests cover nothing in this diff; they only confirm that the tree is unchanged in behaviour.build.ymlanddev-release.yml; the manual runs were read fromgh run list --workflow dev-release.yml.Main.java. It was not exercised with a real command block on a server..mdfiles are indev-release.yml'spaths-ignore, so this merge does not republishdev.Sweep results not changed here
label:bugin the README could not be checked, because the label listing was not available in this session.Skipped issues
pom.xmlto1.0.1-SNAPSHOT, and the release is run outside this repository.git ls-remote --tagsstill shows nov1.0.1.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson